[MC] Unhide the target-abi option. #123135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is very important for RISC-V as it controls calling convention and a field in the ELF header. It is used in a large number of RISC-V lit tests. Expose the option to -help.
Member
|
@llvm/pr-subscribers-mc Author: Craig Topper (topperc) ChangesThis option is very important for RISC-V as it controls calling convention and a field in the ELF header. It is used in a large number of RISC-V lit tests. Expose the option to -help. Full diff: https://github.com/llvm/llvm-project/pull/123135.diff 1 Files Affected:
diff --git a/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp b/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp
index abaf0f0246183e..2adc29172f9ddf 100644
--- a/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp
+++ b/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp
@@ -156,7 +156,7 @@ llvm::mc::RegisterMCTargetOptionsFlags::RegisterMCTargetOptionsFlags() {
MCBINDOPT(X86Sse2Avx);
static cl::opt<std::string> ABIName(
- "target-abi", cl::Hidden,
+ "target-abi",
cl::desc("The name of the ABI to be targeted from the backend."),
cl::init(""));
MCBINDOPT(ABIName);
|
arichardson
approved these changes
Jan 16, 2025
Member
arichardson
left a comment
arichardson
left a comment
There was a problem hiding this comment.
I use this all the time and didn't know it was hidden. Making it visible is a good improvement!
MaskRay
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is very important for RISC-V as it controls calling convention and a field in the ELF header. It is used in a large number of RISC-V lit tests.
Expose the option to -help.
Fixes one issue raised in #123077